Fix windows version #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detect mbed-cli by using 'where' command on windows use uri.fsPath instead of uri.path for windows compatibility
adding ' -f' option to mbed compile command for flashing after compiling. Needs 'auto' or 'detect' option as target setting.
|
JojoS62, while you're at it.. can you also fix the typo "complied" to "compile". There are 3 of them. Thanks! |
|
done, but it looks like the author has not time or is not interested in merging the PR. |
|
So, what about creating a fork on the marketplace then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix the problems when running the extension under windows.
It also adds the flash function to the flash command, the ' -f' option was missing. Please note that flashing requires 'auto' or 'detect' for the target setting.
The excecution of the compile command under windows failed because the path is prepended by a '/'. The variable vscode.workspace.workspaceFolders[0].uri.fsPath contains the correct path.